Gnmic prom #54
Gnmic prom #54
Conversation
| @@ -0,0 +1,26 @@ | |||
| { | |||
| // "image": "ghcr.io/${localEnv:GITHUB_REPOSITORY}/lab-base:python3.11-avd-v4.10.2-clab0.57.5-rev9", | |||
There was a problem hiding this comment.
remove the commented line pointing to rev9
I know, it comes from other lab where it was not cleaned as well after experimenting, but there will one less to clean after removal
There was a problem hiding this comment.
this image is a bit weird as links do not end on the switches. Would be great to update if possible, but not critical.
Also light version is preferred for images as it's easier to match both light and dark background with { .opacity09 }. For example: { .opacity09 }
This is not yet enforced on acLabs, just a nice to have.
docs/assets/img/ceos-download.png
Outdated
There was a problem hiding this comment.
I'd suggest to refer to the acLabs quickstart guide here to avoid maintaining duplicate content.
There was a problem hiding this comment.
Should be part of the acLabs quickstart as well. However it's not yet covered there. So we have 2 options:
- remove it from telemetry docs and add to quickstart (now or later)
- keep it in the telemetry docs, and move later in a dedicated PR
docs/assets/img/devcontainer.png
Outdated
| import_role: | ||
| name: arista.avd.eos_cli_config_gen | ||
|
|
||
| - name: Deploy generated configuration to devices |
There was a problem hiding this comment.
I'd prefer to have separate playbooks for various steps, like here. Called by make shortcuts.
Certainly it's fine to have combined build and deploy on top.
|
|
||
| !!! Success "Container Requirements" | ||
|
|
||
| CPUs: 8 |
There was a problem hiding this comment.
must be on a separate line each - add double space at the end or similar
docs/telemetry.md
Outdated
| - Only x86 CPU architecture is supported! | ||
| - ARM support coming soon! | ||
|
|
||
| ### How To Run The Workshop |
There was a problem hiding this comment.
Shorten this section and refer to the Quickstart guide
| - download one of the prepackage AVD+Python+Containerlab containers from [aclabs packages](https://github.com/aristanetworks/aclabs/pkgs/container/aclabs%2Flab-base) | ||
| - when running the lab locally, you must set all required environment variables on your machine | ||
|
|
||
| ### Run it in Codespaces |
There was a problem hiding this comment.
Combine this with the previous section, refer to the Quickstart and only leave what is relevant for this specific lab, like the screenshot with the 3001 port.
| ansible-playbook playbooks/fabric-deploy-config.yaml -i inventory.yaml | ||
| ``` | ||
|
|
||
| ### How To Run The Lab on Your Machine |
There was a problem hiding this comment.
We can keen everything below this header for now. But definitely this has to be moved out of the lab guide over time. Somewhere to Home section.
docs/telemetry.md
Outdated
|
|
||
| ### Run it in Codespaces | ||
|
|
||
| [Start :octicons-play-16: gNMIc-Prometheus-Grafana Lab :octicons-mark-github-24:](https://codespaces.new/noredistribution/aclabs/tree/main?quickstart=1&devcontainer_path=.devcontainer%2Fgnmic-prometheus-grafana%2Fdevcontainer.json){ .md-button .md-button--primary target=_blank} |
There was a problem hiding this comment.
Don't forget to update before merging! This kind of things will be addressed with templating later.
Change Summary
Adding OpenConfig telemetry lab that will be leveraged on the openmgmt website
Related Issue(s)
fixes #
Repository Checklist
mainbranch